Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #14

Merged
merged 9 commits into from
Feb 3, 2025
Merged

Bug fixes #14

merged 9 commits into from
Feb 3, 2025

Conversation

jiqiang90
Copy link
Collaborator

@jiqiang90 jiqiang90 commented Jan 22, 2025

Description

Fix various issues:

  • use getBlockWithReceipts
  • improve types
  • clean up code

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

github-actions bot commented Jan 22, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 47.96% 2257/4706
🟡 Branches 66.57% 237/356
🔴 Functions 52.48% 106/202
🔴 Lines 47.96% 2257/4706

Test suite run success

45 tests passing in 11 suites.

Report generated by 🧪jest coverage report action from 7509046

packages/node/src/starknet/api.starknet.ts Outdated Show resolved Hide resolved
packages/node/src/starknet/block.starknet.ts Outdated Show resolved Hide resolved
packages/node/src/starknet/block.starknet.ts Outdated Show resolved Hide resolved
packages/node/src/starknet/api.starknet.ts Outdated Show resolved Hide resolved
packages/node/src/starknet/api.starknet.ts Outdated Show resolved Hide resolved
packages/node/src/starknet/block.starknet.ts Outdated Show resolved Hide resolved
packages/types/src/starknet/utils.ts Outdated Show resolved Hide resolved
@stwiname stwiname merged commit bc9b9f6 into main Feb 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants